Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FTB Egg #54

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix FTB Egg #54

wants to merge 6 commits into from

Conversation

MadsKelberg
Copy link

@MadsKelberg MadsKelberg commented Jan 11, 2025 •
edited
Loading

Description

The FTB Egg does not currently work with the new FTB API #53.

Added Java 21 docker image, which is required by some new modpacks.

The install script used jdk 8 slim, which caused trouble when downloading the modpack server from FTB.
Instead it now uses jdk 21 slim.

The symlink for NeoForge unix_args was looking at the wrong directory, so that was also fixed.

I tested it with the FTB Direwolf20 newest version (1.8.2) and FTB Skies: Expert oldest version (1.0.1)

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@MadsKelberg
Copy link
Author

This should also resolve #46

@QuintenQVD0
Copy link
Contributor

This fille should use the egg-pterodactyl-name.json as it is exported from pterodactyl, all features are missing from the egg and please don't use the pterodactyl images as they have not been updated for months

@MadsKelberg
Copy link
Author

@QuintenQVD0 Okay, I will update the name.
What do you mean by all features are missing from the egg?
Which images am I suppose to use if not pterodactyl images?

@QuintenQVD0
Copy link
Contributor

@QuintenQVD0 Okay, I will update the name. What do you mean by all features are missing from the egg? Which images am I suppose to use if not pterodactyl images?

"features": null, -->

        "features": [
        "eula",
        "java_version",
        "pid_limit"
    ],

https://github.com/pelican-eggs/yolks?tab=readme-ov-file#java

MadsKelberg and others added 2 commits January 13, 2025 21:27
@MadsKelberg
Updated egg
47e2984 
Added "features" to egg.
Changed pterodactyl images to parkervcp images.
@QuintenQVD0
Add back the pelican egg
8be0cbb
This was linked to issues Feb 18, 2025
[Bug]: FTB #53
Open
[Bug]: FTB : Not Renaming The Server.jar #46
Open
QuintenQVD0
QuintenQVD0 reviewed Feb 18, 2025
View reviewed changes
java/ftb/README.md
- FTB_MODPACK_VERSION_ID: the version id in the api.
EX: for FTB: Interactions 2.0.2 the id is "86". `https://api.modpacks.ch/public/modpack/5/86`
EX: for FTB: Interactions 2.0.2 the id is "86". `https://api.feed-the-beast.com/v1/modpacks/public/modpack/5/86`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link points to a "Modpack version not found"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintenQVD0 QuintenQVD0 QuintenQVD0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: FTB [Bug]: FTB : Not Renaming The Server.jar
2 participants
@MadsKelberg @QuintenQVD0