Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library does not work with Rails 5.1 due to use of before_filter #157

Open
kevinburkeomg opened this issue May 15, 2018 · 1 comment
Open

Comments

@kevinburkeomg
Copy link

If you try to include this library with Rails 5.1, you get the following error:

Failure/Error: include Oauth::Controllers::ConsumerController

NoMethodError:
  undefined method `before_filter' for OAuthConsumersController:Class
  Did you mean?  before_action
# ./vendor/bundle/ruby/2.4.0/gems/oauth-plugin-0.5.1/lib/oauth/controllers/consumer_controller.rb:6:in `block in included'
# ./vendor/bundle/ruby/2.4.0/gems/oauth-plugin-0.5.1/lib/oauth/controllers/consumer_controller.rb:5:in `class_eval'
# ./vendor/bundle/ruby/2.4.0/gems/oauth-plugin-0.5.1/lib/oauth/controllers/consumer_controller.rb:5:in `included'
# ./app/controllers/oauth_consumers_controller.rb:3:in `include'
# ./app/controllers/oauth_consumers_controller.rb:3:in `<class:OAuthConsumersController>'
# ./app/controllers/oauth_consumers_controller.rb:2:in `<top (required)>'

before_filter was removed in Rails 5.1, so this library isn't compatible. It looks like #156 will fix the issue.

@JorgeLAB
Copy link

I believe t gem is no longer sustained.

t last commit,
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants