Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BTRFS Support #158

Closed
liberodark opened this issue May 22, 2021 · 9 comments · Fixed by #264
Closed

Add BTRFS Support #158

liberodark opened this issue May 22, 2021 · 9 comments · Fixed by #264

Comments

@liberodark
Copy link
Contributor

liberodark commented May 22, 2021

Hi,

I want to build a project on BTRFS.
But genimage only support ext2, ext3, ext4...
Can you have possibility to add btrfs support.

Best Regards.

@michaelolbrich
Copy link
Member

I don't use btrfs myself so this has a low priority for me. But I would be happy to review a merge request.

@liberodark
Copy link
Contributor Author

Ok im poke @rtissera when you have time to check that.

@lePereT
Copy link

lePereT commented Aug 20, 2021

This would be great to have. Is there any kind of guide other than the source code for how to add new filesystems + tests?

@michaelolbrich
Copy link
Member

No docs really

About the implementation, this is split into two parts:

  • The setup function validates the configuration and maybe adds some stuff to the fs specific struct. Note, that the input files are not yet available at this point.
  • The generate function actually writes the filesystem image. We try to make things reproducible here. E.g. try to avoid system config files like we do with mke2fs.conf

For tests:

  • Define tools that are needed as prerequisites (that's the exec_test_set_prereq in other tests)
  • run genimage
  • do something to validate the result. Usually by comparing the output of some tool with a file that contains the expected output.

@liberodark
Copy link
Contributor Author

liberodark commented Mar 6, 2022

Hi,

Any new about this feature ?

Best Regards

@liberodark
Copy link
Contributor Author

liberodark commented May 17, 2022

Hi, @Harvie

I saw that you had added F2FS do you think you can add BTRFS ?
I think it might be useful for you too for PR: #191
Because the BTRFS has a RAID system too and it is simpler than mdam.

Best Regards

@yodatak yodatak mentioned this issue Nov 12, 2022
@yodatak
Copy link

yodatak commented Nov 12, 2022

Hello some try to implent this i hope it help batocera ;) @liberodark

#206

@Harvie
Copy link
Contributor

Harvie commented Jan 12, 2024

Hello some try to implent this i hope it help batocera ;)

Thanks for great work! It seems other guys have requested you to make few changes to your code in #206 before it can be merged to official genimage repository. This is not unusual thing to happen and it does help to maintain genimage codebase in top shape, so please don't get discouraged by it.

This was referenced Jan 18, 2024
@liberodark
Copy link
Contributor Author

liberodark commented Jan 18, 2024

Thank you @yodatak
Have make a PR for try to merge this fonctionnality.
Based on #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants