Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCOUNT_EMAIL_VERIFICATION customizable dinamically in AccountAdapter #1946

Open
rocchidavide opened this issue Feb 13, 2018 · 6 comments
Open

Comments

@rocchidavide
Copy link

Is it possible to set or change ACCOUNT_EMAIL_VERIFICATION in AccountAdapter? I'm trying to set as 'mandatory' for the company user profile, and 'optional' for the private user profile.

@derek-adair
Copy link

I solved this w/ a single account adapter that has logic for this by reading an account_type field. Not sure how worthy this is to add BUT i would use it.

Would it be silly to have it look for a defined field and let users override w/ a form defaulting to the setting? How else might this be achieved?

@pennersr
Copy link
Owner

It would definitely be useful to have a adapter.get_email_verification_method(user) method available.

@derek-adair
Copy link

Could probably add "help wanted" tag, this seems like a good entry level PR for someone looking to get involved.

@Hk669
Copy link

Hk669 commented Sep 28, 2023

hey @pennersr can you give me a brief on this issue, i wanna work on this issue.

@pennersr
Copy link
Owner

This should be it:

  • Add a get_email_verification_method(self, email): return app_settings.app_settings.EMAIL_VERIFICATION to the account adapter
  • Replace references to app_settings.EMAIL_VERIFICATION with a call to that method.

muneeb706 added a commit to muneeb706/django-allauth that referenced this issue Feb 19, 2024
@muneeb706
Copy link

I have tried adding this feature in PR: #3648

muneeb706 added a commit to muneeb706/django-allauth that referenced this issue Feb 19, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 1, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 1, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 1, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 1, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 1, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 1, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 1, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 1, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 2, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 2, 2024
muneeb706 added a commit to muneeb706/django-allauth that referenced this issue May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants