Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base -> Display pricing fix #149

Open
grod220 opened this issue Nov 21, 2024 · 0 comments
Open

Base -> Display pricing fix #149

grod220 opened this issue Nov 21, 2024 · 0 comments

Comments

@grod220
Copy link
Contributor

grod220 commented Nov 21, 2024

With #139 merged, we now have utilities to return the correct price exponent to the frontend:

  • calculateDisplayPrice() -> takes a base/base price and converts it to a display/display price. EDIT: Should be moved as frontend responsibility. Need to likely pass price w/ Metadata and create a type to serialize/deserialize.
  • For other things that are integers (pricing requires decimals), we can use toValueView() to pass that on to the frontend where ValueViewComponent handles the display. Note, this requires serialization to handle passing it over the wire to the frontend, see SummaryDataResponse and SummaryDataResponseJson classes as an example.

The task is to update the pricing in the candles & route book.

@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Nov 21, 2024
@grod220 grod220 moved this to 📝 Todo in Labs web Nov 21, 2024
@grod220 grod220 added this to Labs web Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🗄️ Backlog
Development

No branches or pull requests

1 participant