Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge candle logic update #151

Closed
grod220 opened this issue Nov 22, 2024 · 2 comments · Fixed by #159
Closed

Merge candle logic update #151

grod220 opened this issue Nov 22, 2024 · 2 comments · Fixed by #159
Assignees

Comments

@grod220
Copy link
Contributor

grod220 commented Nov 22, 2024

@cronokirby to update pindexer to handle candlestick merging. The API route can remove all merge logic and rely on the single-direction query from the database.

Secondly, the backend should pass base-denominated values back to the frontend who is responsible for doing the base->display conversions.

@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Nov 22, 2024
@grod220 grod220 moved this to 📝 Todo in Labs web Nov 22, 2024
@grod220 grod220 added this to Labs web Nov 22, 2024
@cronokirby
Copy link
Contributor

I think on the dex explorer side the change should just be to only make one database query, and pindexer itself should worry about making the chart have both pieces of information. On the dex ex side we should just need the frontend to fill in empty candles (on the frontend, to not transfer that data)

@grod220
Copy link
Contributor Author

grod220 commented Nov 22, 2024

Ah, in that case, will revise the description and please ping this issue when the merging can be removed from the API please 🙏

@grod220 grod220 moved this from 📝 Todo to 🗄️ Backlog in Labs web Nov 22, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 🏗 In progress in Labs web Nov 25, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Nov 25, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Labs web Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants