fix: update FMD parameters when needed in compact block #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Failure
cronokirby
reviewed
Jul 17, 2024
redshiftzero
changed the title
cronokirby
approved these changes
Jul 17, 2024
which means this is a consensus-breaking change, no? There's no rationale in the PR text explaining why it isn't a consensus-breaking change, so I'm adding the tag. Please remove if I've misunderstood. |
conorsch
added
the
consensus-breaking
|
It breaks consensus only for a dynamic FMD algorithm |
|
This would need to be added in a chain upgrade, then, and there are currently no plans for chain upgrades, pending emergence of a community-driven upgrade process. So we'd need to icebox it for now. |
conorsch
requested changes
Jul 24, 2024
|
Closing for now, we can reopen once there's some community noise about preparing an upgrade that would include this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This fixes the compact block generation such that updated FMD parameters are provided. This is required to use an algorithm in the future that dynamically updates the FMD parameters (see #1087)
Issue ticket number and link
Closes #4714
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: