Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovering the position id of a new LP position created with pcli is high friction #4792

Closed
zmanian opened this issue Aug 6, 2024 · 2 comments
Closed

Discovering the position id of a new LP position created with pcli is high friction #4792

zmanian opened this issue Aug 6, 2024 · 2 comments
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@zmanian
Copy link
Contributor

zmanian commented Aug 6, 2024

When creating an lp position with pcli tx lp order buy, you get a transaction_hex back but a more typical workflow would be to either monitor the position with pcli query dex position or with the dex explorer.

To do that step, you need your position id. My current workflow is to call pcli view balance and look all my open position_nfts to find the one that was created.

Describe the solution you'd like

It would be useful to either have a position specific view that would basically show richer information about all open positions and/or it would be useful to have the pcli tx lp order buy/sell commands return a position_id.
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Aug 6, 2024
@hdevalence
Copy link
Member

One very low effort improvement is that the command should print out the position ID before submitting the TX

zmanian added a commit to zmanian/penumbra that referenced this issue Aug 9, 2024
@zmanian
Print the position id when generating a position
a0b6109 
Resolves issue penumbra-zone#4792
@zmanian zmanian mentioned this issue Aug 9, 2024
Merged
aubrika pushed a commit that referenced this issue Aug 12, 2024
@zmanian @hdevalence
Print the position id when generating a position (#4798)
897b59d 
Resolves issue #4792 

Prints the position Id when creating a new liquidity position

---------

Signed-off-by: Henry de Valence <[email protected]>
Co-authored-by: Henry de Valence <[email protected]>
conorsch pushed a commit that referenced this issue Aug 12, 2024
@zmanian @conorsch
Print the position id when generating a position (#4798)
2702f34 
Resolves issue #4792

Prints the position Id when creating a new liquidity position

---------

Signed-off-by: Henry de Valence <[email protected]>
Co-authored-by: Henry de Valence <[email protected]>
(cherry picked from commit 897b59d)
conorsch pushed a commit that referenced this issue Aug 12, 2024
@zmanian @conorsch
Print the position id when generating a position (#4798)
7fd39b6 
Resolves issue #4792

Prints the position Id when creating a new liquidity position

---------

Signed-off-by: Henry de Valence <[email protected]>
Co-authored-by: Henry de Valence <[email protected]>
(cherry picked from commit 897b59d)
@cronokirby
Copy link
Contributor

Resolved in #4798, for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hdevalence @zmanian @cronokirby