Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove makeApprovalRequest from provider #1522

Closed
grod220 opened this issue Jul 22, 2024 · 0 comments
Closed

Remove makeApprovalRequest from provider #1522

grod220 opened this issue Jul 22, 2024 · 0 comments

Comments

@grod220
Copy link
Collaborator

grod220 commented Jul 22, 2024

web/packages/react/src/components/penumbra-context-provider.tsx

Line 22 in f515113

makeApprovalRequest = false,

Consumers should thoughtfully acquire approval requests via a connect button. Auto-approval requests are an anti-pattern in crypto and have been known to annoy users.

Todo: Remove makeApprovalRequest from hook + logic for auto approval requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Penumbra web
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grod220