Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounts on the assets page are not ordered #1593

Closed
Valentine1898 opened this issue Jul 30, 2024 · 1 comment · Fixed by #1685
Closed

Accounts on the assets page are not ordered #1593

Valentine1898 opened this issue Jul 30, 2024 · 1 comment · Fixed by #1685
Assignees
@VanishMax
Labels
bug Something isn't working ui Related to user interface or ux design

Comments

@Valentine1898
Copy link
Contributor

Describe the bug
Accounts on the assets page are not ordered
For some reason Account #8 is higher than Accounts #2, #6, #7

Expected behavior
Accounts should be sorted in ascending order of their address indexes

Screenshots

image
@Valentine1898 Valentine1898 added the bug Something isn't working label Jul 30, 2024
VanishMax added a commit that referenced this issue Aug 1, 2024
@VanishMax
fix(minifront): #1593: display non-native-fee-warning per account
f3c73d2
@turbocrime
Copy link
Contributor

it appears they are in lexical order of address

@turbocrime turbocrime added the ui Related to user interface or ux design label Aug 2, 2024
VanishMax added a commit that referenced this issue Aug 2, 2024
@VanishMax
fix(minifront): #1598: display non-native-fee-warning per account (#1614
f983923 
)

* fix(minifront): #1593: display non-native-fee-warning per account

* fix(minifront): #1598: fix linter

* chore: changeset

* fix(#1598): check for alt token balances before rendering non-native-fee-warning

* chore: format

* fix(minifront): #1598: comments

* fix(minifront): #1598: fix display of the fee warning

* fix(#1598): refactor
@VanishMax VanishMax self-assigned this Aug 12, 2024
VanishMax added a commit that referenced this issue Aug 12, 2024
@VanishMax
fix(minifront): #1593: sort asset groups by account index
4bb874f
@VanishMax VanishMax mentioned this issue Aug 12, 2024
Merged
VanishMax added a commit that referenced this issue Aug 12, 2024
@VanishMax
fix(minifront): #1593: sort asset groups by account index (#1685)
ef54d56 
* fix(minifront): #1593: sort asset groups by account index

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VanishMax VanishMax

Labels
bug Something isn't working ui Related to user interface or ux design
Projects
Penumbra web
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(minifront): #1593: sort asset groups by account index penumbra-zone/web
3 participants
@Valentine1898 @VanishMax @turbocrime