Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you have crumbs of native token on your balance, the alt fee asset will not be used #1595

Open
Valentine1898 opened this issue Jul 30, 2024 · 6 comments
Assignees
Labels
bug Something isn't working enhancement fees

Comments

@Valentine1898
Copy link
Contributor

Describe the bug
If you have a small native token balance that is not enough to pay the fee, you will not be able to use alt fee assets

Expected behavior
The user should be able to manually select the fee asset in this case

Screenshots
image
image

@Valentine1898 Valentine1898 added the bug Something isn't working label Jul 30, 2024
@TalDerei
Copy link
Contributor

TalDerei commented Jul 30, 2024

this is something we should definitely follow-up on.

@hdevalence
Copy link
Member

Yes, but lower priority than making sure that fees work when there are no native tokens.

@TalDerei
Copy link
Contributor

TalDerei commented Aug 20, 2024

just a thought from a ux perspective, one alternative could be to implement some kind of UI callback – define a custom rust error type, detect the error in wasm, propagate it up the call stack to the caller, and handle it in typescript by automatically retrying the transaction with another fee asset. But replanning a transaction and retriggering the popup doesn't seem like a good idea to me. cc @grod220

@TalDerei
Copy link
Contributor

TalDerei commented Aug 20, 2024

do we generally want to implement manual fee selection as a product feature?

@hdevalence
Copy link
Member

Don't think so, we can revisit this as soon as a single user complains about it

@TalDerei
Copy link
Contributor

moving back to backlog for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement fees
Projects
Status: 🗄️ Backlog
Development

No branches or pull requests

3 participants