Block processor fails to set gas prices from a compact block

[turbocrime]

web/packages/query/src/block-processor.ts

Lines 171 to 178 in 69b0837

	if (compactBlock.gasPrices) {
	await this.indexedDb.saveGasPrices(
	new GasPrices({
	assetId: this.stakingAssetId,
	...compactBlock.gasPrices,
	}),
	);
	}

When the assetId in compactBlock.gasPrices is set to undefined (not absent, but a present value of undefined), spreading it after attaching an assetId to the object will clobber the assetId which was just set.

But, the idb table requires an asset id for the keypath. So this setGasPrices call will throw an error and prevent sync from progressing.

I believe this is at the root of some of the 'long sync time' issues reported by users.

[grod220]

Yep worth adjusting the logic. However, no user should be encountering this as all blocks that contain new gas prices have included an assetId.

Edit: Correction, some include assetId and some exclude it. But none explicitly have undefined set as that field (which feels like is consistent with the Typescript type given by bufbuild for the type).

[TalDerei]

still unclear if this can be closed