getNotesForVoting performs invalid AddressIndex comparison

[turbocrime]

web/packages/storage/src/indexed-db/index.ts

Lines 460 to 469 in 69b0837

	for await (const noteCursor of this.db.transaction('SPENDABLE_NOTES').store) {
	const note = SpendableNoteRecord.fromJson(noteCursor.value);
	if (
	(addressIndex && !note.addressIndex?.equals(addressIndex)) ??
	!note.note?.value?.assetId?.inner
	) {
	continue;
	}

similar to #1604 and #1601

[grod220]

Yes, we should create a hasTokenBalance helper here and write a test case for this. The reason why no users would realistically run into this is because it would only error if someone ibc'd out a delegation token and ibc'd it back in to an ephemeral address.

[Valentine1898]

The reason why no users would realistically run into this is because it would only error if someone ibc'd out a delegation token and ibc'd it back in to an ephemeral address.

delUM can simply be sent to the ephemeral address, it is not necessary to use ibc out + ibc in to do this
This issue is not a priority anyway, because the issue is only notesForVoting RPC (which probably nobody uses), while planner ignores randomizer

web/packages/wasm/crate/src/storage.rs

Lines 103 to 108 in 2c0c167

	// Planner should omit the address index randomizer and compare only the account index
	if let Some(ai) = address_index {
	if record.address_index.account != ai.account {
	continue;
	}
	}