Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Noble withdraws #1656

Closed
grod220 opened this issue Aug 7, 2024 · 0 comments · Fixed by #1658
Closed

Re-enable Noble withdraws #1656

grod220 opened this issue Aug 7, 2024 · 0 comments · Fixed by #1658
Assignees
Labels
priority Important to work on next rpc Related to proto rpc services/methods

Comments

@grod220
Copy link
Collaborator

grod220 commented Aug 7, 2024

Following the v0.80.0 core release, clients now have the ability to use the new useCompatAddress flag that fixes issues with Ics20Withdraws to chains that use the bech32 address standard (versus bech32m).

Updates required to enable Noble

penumbra-zone/web pt. 1 updates - #1623 (merged ✅ )

  • bump penumbra crate deps to v0.80.0
  • bump decaf377 v0.10.1 (@TalDerei fyi)
  • bump bufbuild types in penumbra-zone/web
  • Update action views to include useCompact flag (tx details page)
  • Note: do not remove the Noble blocker yet in the UI
  • Userflows to test (with current extension version):
    • Current IBC userflows (eg. UM -> Osmosis, OSMO -> osmosis)
  • publish new versions to npm Version Packages #1650

prax-wallet/web updates - prax-wallet/prax#144 (merged ✅ )

  • Updates to latest penumbra-zone/packages (from above)
  • Update action views to include useCompact flag (approval dialog)
  • Userflows to test on penumbra-1:
    • USDC deposit, USDC withdraw with no other assets in account (tests multi-asset fees)
    • USDC withdraw to noble using UM as gas
    • Send UM to noble. Note: This is sort of a strange userflow (along with UM->cosmos hub) as UM isn't listed in those respective registries, wallets don't recognize it, and there isn't really anything you can do with UM on those chains.
    • Misc other Ics20Withdraws to ensure no breakage with already working chains.
  • Submit for Chrome Review (pending ⚠️)
  • Wait 24 hours for approval before moving to last step

penumbra-zone/web updates pt. 2 - #1658

  • In the UI, remove the block on Noble transfers
  • Merge
  • Wait to see latest commit on auto-deploy frontends. Will happen within 6 hours.
  • Notify Radiant that UI fixes are coming soon

Comms

Radiant to issue discord message + tweets about re-enabled feature

@grod220 grod220 self-assigned this Aug 7, 2024
@grod220 grod220 added rpc Related to proto rpc services/methods priority Important to work on next labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Important to work on next rpc Related to proto rpc services/methods
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant