Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explore externally_connectable #785

Closed
turbocrime opened this issue Mar 18, 2024 · 4 comments
Closed

explore externally_connectable #785

turbocrime opened this issue Mar 18, 2024 · 4 comments
Assignees
@turbocrime
Labels
concept

Comments

@turbocrime
Copy link
Contributor

externally_connectable supports https://* permission, which might be preferable to the DOM channel session and forwarding we currently implement
@grod220 grod220 added the mainnet label Apr 2, 2024
@grod220
Copy link
Collaborator

grod220 commented Apr 25, 2024

From meeting:

  • Add to the manifest
  • Have a very small use of it in the codebase
  • Submit for approval (with reasons in the chrome dev dashboard)

@grod220
Copy link
Collaborator

grod220 commented Apr 29, 2024

Reference docs: https://developer.chrome.com/docs/extensions/reference/manifest/externally-connectable

It does not appear that externally_connectable allows for <all_urls> match pattern. Think this may be a blocker for us.

@turbocrime
Copy link
Contributor Author

the documentation is outdated, it has been patched to support TLD wildcards

@turbocrime
Copy link
Contributor Author

permission added by #1144 and work for v2 in #1145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turbocrime turbocrime

Labels
concept
Projects
Penumbra web
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grod220 @turbocrime