You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Detecting presence of a browser shouldn't depend on hard-coded absolute paths, and should handle a little variation in bin name (e.g. "chromium-browser" vs "chromium").
I'm going to submit a PR that attempts to improve this with the help of an extra python dep (plumbum). I understand if it's desirable to implement this without an extra dep, but at least it will serve as an example.
The text was updated successfully, but these errors were encountered:
how about solving this with subprocess module (should be more widely installed already I'd say). I have not submitted a PR yet, but maybe you can take a look at my fork at https://github.com/rhein/ice - it also contains some other fixes I found useful for myself.
Detecting presence of a browser shouldn't depend on hard-coded absolute paths, and should handle a little variation in bin name (e.g. "chromium-browser" vs "chromium").
I'm going to submit a PR that attempts to improve this with the help of an extra python dep (plumbum). I understand if it's desirable to implement this without an extra dep, but at least it will serve as an example.
The text was updated successfully, but these errors were encountered: