Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_library : "depends" property #31

Open
tobozo opened this issue Jun 27, 2020 · 1 comment
Open

install_library : "depends" property #31

tobozo opened this issue Jun 27, 2020 · 1 comment

Comments

@tobozo
Copy link

tobozo commented Jun 27, 2020

Hello and thanks again for this awesome script 👍

I've recently moved a source subtree from github submodule to a declaration in the library.json and library.properties file, and the Arduino IDE seems to prompt for installation of the dependency as expected.

While adding an extra line to my travis.yml isn't an issue at all, I was wondering if having check_library_properties to read the "depends" values in the library.properties file would make sense ?

@per1234
Copy link
Owner

per1234 commented Jun 27, 2020

You're welcome, and I'm glad if you have found it useful.

This is indeed something I have considered after seeing Adafruit do it in their CI script:
https://github.com/adafruit/ci-arduino/blob/44550ac828c25a8b4cd9744111f063ada3d35368/build_platform.py#L156-L170

I've been working lately on reproducing the functionality of this script in Arduino's official GitHub Actions actions:
https://github.com/arduino/actions/tree/master/libraries
So, for now, I'm holding off on doing work to add additional features to this script until I see whether it will eventually be possible to deprecate it in favor of the official CI tools.

I have already proposed that this feature be added to Arduino's compile-examples action.

It's not a perfect solution to installing dependencies for CI because I have found that many library authors will only add the dependencies of the library itself, but not additional dependencies the library's example sketches might have. However, the additional dependencies can always be installed via install_library as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants