distinguish v6 IP addresses in RaftAdvertise host

chernomor · chernomor · commit 3a4d367e1249 · 2024-08-20T19:21:52.000+03:00
Avoid error when RaftAdvertise is IPv6 address:
ERROR failed to open raft store: address fcff:0:675:2::bf87:10008: too many colons in address
diff --git a/go/raft/raft.go b/go/raft/raft.go
@@ -188,7 +188,12 @@ func normalizeRaftHostnameIP(host string) (string, error) {
 	}
 	// resolve success!
 	for _, ip := range ips {
-		return ip.String(), nil
+		addr := net.ParseIP(ip.String())
+		if addr != nil && addr.To4() == nil {
+			return fmt.Sprintf("[%s]", ip.String()), nil
+		} else {
+			return ip.String(), nil
+		}
 	}
 	return host, fmt.Errorf("%+v resolved but no IP found", host)
 }

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,12 @@ func normalizeRaftHostnameIP(host string) (string, error) {`
`188`	`188`	`}`
`189`	`189`	`// resolve success!`
`190`	`190`	`for _, ip := range ips {`
`191`		`- return ip.String(), nil`
	`191`	`+ addr := net.ParseIP(ip.String())`
	`192`	`+ if addr != nil && addr.To4() == nil {`
	`193`	`+ return fmt.Sprintf("[%s]", ip.String()), nil`
	`194`	`+ } else {`
	`195`	`+ return ip.String(), nil`
	`196`	`+ }`
`192`	`197`	`}`
`193`	`198`	`return host, fmt.Errorf("%+v resolved but no IP found", host)`
`194`	`199`	`}`