K8SPSMDB-1276: Optimize TLS and CA certificate file writes in getMongoUri function #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clsv
requested review from
hors,
egegunes,
inelpandzic and
pooknull
as code owners
|
|
egegunes
changed the title
gkech
reviewed
Feb 10, 2025
gkech
approved these changes
Feb 17, 2025
nmarukovich
approved these changes
Feb 24, 2025
pooknull
approved these changes
Feb 25, 2025
commit: b36c534 |
egegunes
approved these changes
Feb 27, 2025
hors
approved these changes
Feb 28, 2025
|
@clsv, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The function getMongoUri always rewrites the TLS PEM and CA certificate files, even if their content hasn't changed. This unnecessary file I/O is inefficient and may cause issues during critical operations, such as when the operator checks the backup process.
Cause:
The implementation does not verify whether the existing file content matches the secret data before overwriting the files, leading to constant and redundant updates.
Solution:
Added logic to compare the content of the existing files with the secret data. Files are only overwritten if the data has changed, preventing redundant writes and ensuring smoother operations during backup checks.
Resolves #1723