Allow unknown tags by default again (broke other code)

The previous change about forbidding unknown tags by default was
accidentally released as a regular release, and also I didn't think at that
point that many other libraries / tests would depend on the old behaviour.

Author: perlpunk

bin/yamlpp-load

@@ -15,7 +15,7 @@ GetOptions(
     'cyclic' => \my $cyclic,
     'duplicate-keys' => \my $duplicate_keys,
     'merge' => \my $merge,
-    'catchall' => \my $catchall,
+    #'catchall' => \my $catchall,
     'require-footer' => \my $require_footer,
     'perl' => \my $perl,
     'module|M=s' => \my $module,
@@ -35,9 +35,9 @@ if ($merge) {
 if ($perl) {
     push @schema, 'Perl';
 }
-if ($catchall) {
-    push @schema, 'Catchall';
-}
+#if ($catchall) {
+#    push @schema, 'Catchall';
+#}
 
 my ($file) = @ARGV;
 my $yaml;
@@ -143,13 +143,13 @@ Options:
     --cyclic              Allow cyclic references
     --duplicate-keys      Allow duplicate keys
     --merge               Enable loading merge keys '<<'
-    --catchall            Ignore any unknown tags
     --require-footer      Require '...' and the end of each document
     --perl                Enable loading perl types and objects (use only
                           on trusted input!)
     --module -M           YAML::PP (default), YAML, YAML::PP::LibYAML,
                           YAML::Syck, YAML::Tiny, YAML::XS, YAML::PP::Ref
     --yaml-version=       '1.2' (default), '1.1', '1.2,1.1', '1.1,1.2'
 EOM
+    #--catchall            Ignore any unknown tags
     exit $rc;
 }

bin/yamlpp-load-dump

@@ -21,7 +21,7 @@ GetOptions(
     'header!' => \my $header,
     'footer!' => \my $footer,
     'merge' => \my $merge,
-    'catchall' => \my $catchall,
+    #'catchall' => \my $catchall,
     'require-footer' => \my $require_footer,
     'perl' => \my $perl,
     'preserve|P=s' => \my $preserve,
@@ -52,9 +52,9 @@ if ($merge) {
 if ($perl) {
     push @schema, 'Perl';
 }
-if ($catchall) {
-    push @schema, 'Catchall';
-}
+#if ($catchall) {
+#    push @schema, 'Catchall';
+#}
 
 my $preserve_order = 1;
 if (defined $preserve) {
@@ -293,7 +293,6 @@ Options:
     --[no-]header         Print '---' (default)
     --[no-]footer         Print '...'
     --merge               Enable loading merge keys '<<'
-    --catchall            Ignore any unknown tags
     --require-footer      Require '...' and the end of each document
     --perl                Enable loading perl types and objects (use only
                           on trusted input!)
@@ -310,5 +309,6 @@ Options:
     --include-absolute    Allow absolute paths and ../../../ in includes (use
                           only on trusted input!)
 EOM
+#    --catchall            Ignore any unknown tags
     exit $rc;
 }

lib/YAML/PP.pm

@@ -1060,9 +1060,10 @@ YAML 1.1 merge keys for mappings
 
 =item L<YAML::PP::Schema::Catchall>
 
-Adding this allows (and ignores) all unknown tags, like
+Experimental.
 
-    key: !something value
+It was accidentally added in 0.38.1, and unknown tags forbidden.
+This was reverted in 0.39.0
 
 By default they will result in an error.
 

lib/YAML/PP/Schema.pm

@@ -320,9 +320,9 @@ sub load_scalar {
                 }
             }
         }
-        unless ($res) {
-            croak "Unknown tag '$tag'. Use schema 'Catchall' to ignore unknown tags";
-        }
+        #unless ($res) {
+        #    croak "Unknown tag '$tag'. Use schema 'Catchall' to ignore unknown tags";
+        #}
     }
     else {
         $res = $resolvers->{value};
@@ -383,7 +383,7 @@ sub create_sequence {
                 }
             }
         }
-        croak "Unknown tag '$tag'. Use schema 'Catchall' to ignore unknown tags";
+        #croak "Unknown tag '$tag'. Use schema 'Catchall' to ignore unknown tags";
     }
 
     return ($data, $on_data);
@@ -414,7 +414,7 @@ sub create_mapping {
                 }
             }
         }
-        croak "Unknown tag '$tag'. Use schema 'Catchall' to ignore unknown tags";
+        #croak "Unknown tag '$tag'. Use schema 'Catchall' to ignore unknown tags";
     }
 
     return ($data, $on_data);

t/37.schema-catchall.t

@@ -7,17 +7,18 @@ use Data::Dumper;
 use Scalar::Util ();
 use YAML::PP;
 
-my $yp = YAML::PP->new(
-    schema => [qw/ JSON /],
-);
+my $yp = YAML::PP->new();
 my $catch = YAML::PP->new(
-    schema => [qw/ JSON Catchall /],
+    schema => [qw/ + Catchall /],
 );
 
 my $yaml = <<'EOM';
 - !foo null
 EOM
 
+pass "dummy";
+done_testing;
+__END__
 my $data = eval { $yp->load_string($yaml) };
 my $err = $@;
 like $err, qr{Unknown tag '!foo'. Use schema 'Catchall'}, "unknoen tags are fatal by default";