Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace escape characters in Format-String2 #2615

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replace escape characters in Format-String2 #2615

wants to merge 3 commits into from

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jan 30, 2025

PR Summary

Replaces special chars with their printable variants in Format-Nicely, to fix showing such strings in output, especially when code that contains ansi escape sequences is handled.

Fix #2561

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@nohwnd nohwnd marked this pull request as ready for review January 30, 2025 08:14
@nohwnd
Copy link
Member Author

nohwnd commented Jan 30, 2025

Probably related to #2582, even though there we look at 0x01 and don't look at 0x00.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should-BeString: Doesn't handle escape character correctly in error message
1 participant
@nohwnd