Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Count to Should-BeCollection #2567

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add -Count to Should-BeCollection #2567

merged 2 commits into from
Oct 30, 2024

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Oct 7, 2024

PR Summary

Add -Count to Should-BeCollection with the usual caveat of not being able to tell single item array from single item when using | syntax.

Fix #2534

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

johlju
johlju approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nohwnd nohwnd merged commit 65a2a31 into main Oct 30, 2024
11 checks passed
@nohwnd nohwnd deleted the count branch October 30, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest to add an option to assert the correct number of items in a collection to Pester v6
2 participants
@nohwnd @johlju