Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide over not showing up after updating to 1.7.0 #269

Open
samuelpordeus opened this issue Oct 16, 2023 · 2 comments
Open

Slide over not showing up after updating to 1.7.0 #269

samuelpordeus opened this issue Oct 16, 2023 · 2 comments

Comments

@samuelpordeus
Copy link
Contributor

samuelpordeus commented Oct 16, 2023

what is happening

we have a slide over that isn't opening after updating to 1.7.0 and some others aren't respecting the origin (it should come from the right side, but it's not)

clues

i don't think it's related to the changes we made to add close_slide_over_target attr. i suspect that is related to this commit: 2242a9c

how we are calling the component:

<.form for={@form} id={@id} class="grow" phx-target={@myself} phx-change="validate" phx-submit="submit">
  <.slide_over origin="right" max_width="lg" title={@title}>
@samuelpordeus samuelpordeus changed the title Slide over not showing up after updating to 2.7.0 Slide over not showing up after updating to 1.7.0 Oct 16, 2023
@mplatts
Copy link
Contributor

mplatts commented Oct 17, 2023

Hmm. Do you have multiple slide overs on one page? maybe the hardcoded ID needs to be updated like with modal.

@samuelpordeus
Copy link
Contributor Author

@mplatts we had a custom ID, but I noticed that it only works if we remove it and use the hardcoded one instead.

But removing that doesn't solve the animation issue. It should come from the right but it's not:

<.slide_over origin="right" max_width="lg" title={@title}>

Oct-18-2023 09-12-52

we can see here that it displays the correct animation when closing tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants