Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to change CONFIG_ZMK_COMBO_MAX_KEYS_PER_COMBO #1

Open
YHRen opened this issue May 12, 2022 · 4 comments
Open

How to change CONFIG_ZMK_COMBO_MAX_KEYS_PER_COMBO #1

YHRen opened this issue May 12, 2022 · 4 comments

Comments

@YHRen
Copy link

YHRen commented May 12, 2022

Hi @petejohanson

Thank you for the repo. Really enjoy the keyboard.
I think I'm hitting the limit of the default setting of CONFIG_ZMK_COMBO_MAX_KEYS_PER_COMBO=4.
I tried to add CONFIG_ZMK_COMBO_MAX_KEYS_PER_COMBO=6 to zaphod_defconfig file, but it does not seem to work.
Any advice on how to make such change?

Thank you so much!

@petejohanson
Copy link
Owner

Are you building locally or using GH Actions?

@YHRen
Copy link
Author

YHRen commented May 12, 2022

Are you building locally or using GH Actions?

I'm currently using the GH Actions following your tutorials. I'm not so sure how to set up a local environment. The west environment is new to me.

@merlinvn
Copy link
Contributor

merlinvn commented Sep 9, 2022

Hi, is there any update on this? I currently experiment with combo with the following positions: (1,2), (2,3), (1,3) and (1,2,3) but so far the (1,2,3) combo doesn't work.

@merlinvn
Copy link
Contributor

merlinvn commented Sep 24, 2022

Solved it in the GH Adtions build by adding the following step. Other configs can be modified in the similar way.

     - name: List modules (west list)
        run: west list

      - name: update max combos per key
        run: ln="$(($(sed -n '/ZMK_COMBO_MAX_COMBOS_PER_KEY/=' zmk/app/Kconfig)+2))"; sed -i "${ln}s/default \([0-9]*\)/default 16/" zmk/app/Kconfig

      - name: Build Zaphod (west build)
        run: west build -s zmk/app -b zaphod -d build/zaphod -- -DZMK_CONFIG="${GITHUB_WORKSPACE}/config"

nhongooi added a commit to nhongooi/zaphod-config that referenced this issue Mar 13, 2024
nhongooi added a commit to nhongooi/zaphod-config that referenced this issue Mar 13, 2024
nhongooi added a commit to nhongooi/zaphod-config that referenced this issue Mar 13, 2024
nhongooi added a commit to nhongooi/zaphod-config that referenced this issue Mar 13, 2024
nhongooi added a commit to nhongooi/zaphod-config that referenced this issue Mar 13, 2024
nhongooi added a commit to nhongooi/zaphod-config that referenced this issue Mar 13, 2024
nhongooi added a commit to nhongooi/zaphod-config that referenced this issue Mar 13, 2024
nhongooi added a commit to nhongooi/zaphod-config that referenced this issue Mar 13, 2024
chdorner pushed a commit to chdorner/panic34 that referenced this issue Oct 30, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| zmkfirmware/zmk-build-arm | pinDigest |  -> `0979a8d` |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMzAuNCIsInVwZGF0ZWRJblZlciI6IjM4LjEzMC40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.chdorner.com/chdorner/panic34/pulls/1
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants