Switching back to legacy URL parsing as it is breaking in actions run…

…ner environment

.devcontainer/devcontainer.json

@@ -1,10 +1,14 @@
 {
   "name": "Workspace",
-  "image": "ghcr.io/octodemo/development-containers/javascript:base-202401-r1",
-  "extensions": [
-    "dbaeumer.vscode-eslint",
-    "redhat.vscode-yaml",
-    "swellaby.node-pack"
-  ],
-  "postCreateCommand": "npm install"
+  "image": "ghcr.io/octodemo/development-containers/javascript-nodejs-20:base-202408-r2",
+  "postCreateCommand": "npm install",
+  "customizations": {
+    "vscode": {
+      "extensions": [
+        "dbaeumer.vscode-eslint",
+        "redhat.vscode-yaml",
+        "swellaby.node-pack"
+      ],
+    }
+  }
 }

index.js

@@ -85,6 +85,8 @@ run();
 
 function fail(err, message) {
   core.error(err);
+  // Provide a debug controllable stack trace
+  core.debug(err.stack);
 
   if (message) {
     core.setFailed(message);

lib/github-application.js

@@ -3,7 +3,7 @@ const jwt = require('jsonwebtoken')
   , core = require('@actions/core')
   , PrivateKey = require('./private-key')
   , HttpsProxyAgent = require('https-proxy-agent').HttpsProxyAgent
-  , URL = require('url')
+  , url = require('node:url')
   ;
 
 module.exports.create = (privateKey, applicationId, baseApiUrl, timeout, proxy) => {
@@ -57,6 +57,7 @@ class GitHubApplication {
     const token = jwt.sign(payload, this.privateKey, { algorithm: 'RS256' });
     this._client = getOctokit(token, this._githubApiUrl, proxy);
 
+    core.debug(`Attempting to fetch GitHub Application...`);
     return this.client.request('GET /app', {
       mediaType: {
         previews: ['machine-man']
@@ -68,6 +69,7 @@ class GitHubApplication {
         // Store the metadata for debug purposes
         self._metadata = resp.data;
 
+        core.debug(`  GitHub Application resolved: ${JSON.stringify(resp.data)}`);
         return resp.data;
       } else {
         throw new Error(`Failed to load application with id:${this.id}; ${resp.data}`);
@@ -234,12 +236,21 @@ function getProxyAgent(proxy, baseUrl) {
 function proxyExcluded(noProxy, baseUrl) {
   if (noProxy) {
     const noProxyHosts = noProxy.split(',').map(part => part.trim());
-    const baseUrlHost = new URL(baseUrl).host;
-
     core.debug(`noProxyHosts = ${JSON.stringify(noProxyHosts)}`);
-    core.debug(`baseUrlHost = ${baseUrlHost}`);
 
-    return noProxyHosts.indexOf(baseUrlHost) > -1;
+    core.debug(`parsing baseURL: '${baseUrl}'`);
+    // try {
+      // const parsedBaseUrl = new URL(baseUrl);
+    //   core.debug(`parsed = ${parsedBaseUrl}`);
+    //   core.debug(`base url host = '${parsedBaseUrl.host}'`);
+    // } catch (err) {
+    //   core.error(`Failure in parsing the URL object`);
+    //   throw err;
+    // }
+    const parsedBaseUrl = url.parse(baseUrl);
+    core.debug(`parsed host: ${[parsedBaseUrl.host]}`);
+
+    return noProxyHosts.indexOf(parsedBaseUrl.host) > -1;
   }
 }