add webpack config file, tell webpack about mjs files #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR will fix the webpack error about
.mjs
JavaScript modules files. 😄short story: it looks like we cannot consume javascript modules (
.mjs
) files in webpack 4 without telling webpack how to parse those files. the solution that I suggest adds awebpack.config.js
file that tells webpack how to parse the.mjs
file thatd3-circular-sankey
ships.an example to demonstrate a client-code fix for tomshanley/d3-sankey-circular#32