Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DepthReduction #40

Open
petiaccja opened this issue Jul 8, 2018 · 0 comments
Open

DepthReduction #40

petiaccja opened this issue Jul 8, 2018 · 0 comments
Assignees
Labels

Comments

@petiaccja
Copy link
Owner

Componenets

std::optional -> use Binder simply
Port names missing

Implementation

SetWorkgroupSize

Non-descriptive parameter names (w,h,gw,gh etc)
Fullretard O(n) algorithm, use blockCount = (totalCount + blockSize - 1)/blockSize;
Use Vec2u instead of {w,h} pairs

Setup

Factor out Binder creation to its own function
Factor out CSO creation into its own function

InitRenderTarget

Changing depth buffer format may disable node (not verified)

Shader

Don't use define, use const/constexpr
Naming convention not respected (linearize_depth, init, etc.)
Clean old commented code snippets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants