Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing query with same key but different params #2

Open
petterik opened this issue Mar 5, 2018 · 0 comments
Open

Parsing query with same key but different params #2

petterik opened this issue Mar 5, 2018 · 0 comments

Comments

@petterik
Copy link
Owner

petterik commented Mar 5, 2018

What to do about parsing deduped queries like this one:

    '[({:read [:a]} {:param 1})
      ({:read [:a]} {:param 2})]

It should never happen for local reads as query params is pretty much useless (as they are static). Dynamic query params are not allowed.

It did happen for remote queries when working on sulolive. The solution we did back then was to wrap these queries with the designated join-namespace, that have different names. This solution didn't have any problems, as the result of the query was just merged into the app state, and no one was trying to access a specific key in the query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant