Clarify comment regarding the use of WebhookManagedBy for managed objects in createWebhooks function

ryotarai · ryotarai · commit e3031b2dd60d · 2025-10-15T23:19:55.000+09:00
diff --git a/internal/setup/webhooks.go b/internal/setup/webhooks.go
@@ -76,6 +76,8 @@ func createWebhooks(mgr ctrl.Manager, f *forest.Forest, opts Options) error {
 	}
 
 	// Create webhooks for managed objects
+	// Note: We cannot use WebhookManagedBy here because objects validator handles all resource types dynamically (*)
+	// and WebhookManagedBy requires a specific type to be specified with For().
 	{
 		handler := &objects.Validator{
 			Log:    ctrl.Log.WithName("objects").WithName("validate"),

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,8 @@ func createWebhooks(mgr ctrl.Manager, f *forest.Forest, opts Options) error {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`// Create webhooks for managed objects`
	`79`	`+ // Note: We cannot use WebhookManagedBy here because objects validator handles all resource types dynamically (*)`
	`80`	`+ // and WebhookManagedBy requires a specific type to be specified with For().`
`79`	`81`	`{`
`80`	`82`	`handler := &objects.Validator{`
`81`	`83`	`Log: ctrl.Log.WithName("objects").WithName("validate"),`