reverted some of the code and fixed RESQL test failure issue

Author: anilsahoo20

web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py

@@ -483,9 +483,6 @@ def create(self, gid, sid, did):
                                   data=data, dummy=False, conn=self.conn)
             status, res = self.conn.execute_dict(sql)
             if not status:
-                print("Returning from def "
-                                             "create line 486")
-                print(res)
                 return internal_server_error(errormsg=res)
 
             sql = render_template(
@@ -495,9 +492,6 @@ def create(self, gid, sid, did):
 
             status, r_set = self.conn.execute_dict(sql)
             if not status:
-                print(
-                    "Returning from def create line 498")
-                print(r_set)
                 return internal_server_error(errormsg=r_set)
 
             return jsonify(
@@ -510,9 +504,6 @@ def create(self, gid, sid, did):
             )
 
         except Exception as e:
-            print(
-                "Returning from def create exception line 513")
-            print(str(e))
             return internal_server_error(errormsg=str(e))
 
     @check_precondition

web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/17_plus/create_subscription_msql.sql

@@ -1,4 +1,4 @@
 CREATE SUBSCRIPTION test_create_subscription
     CONNECTION 'host=localhost port=5434 user=postgres dbname=postgres connect_timeout=10 password=xxxxxx sslmode=prefer'
     PUBLICATION test_publication
-    WITH (connect = true, enabled = false, copy_data = false, create_slot = false, slot_name = test_create_subscription, synchronous_commit = 'remote_apply', binary = true, streaming = 'True', two_phase = true, disable_on_error = true, run_as_owner = true, password_required = true, origin = 'any', failover = false);
+    WITH (connect = false, enabled = false, copy_data = false, create_slot = false, slot_name = test_create_subscription, synchronous_commit = 'remote_apply', binary = true, streaming = 'True', two_phase = true, disable_on_error = true, run_as_owner = true, password_required = true, origin = 'any', failover = false);

web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/17_plus/test.json

@@ -1,54 +1,5 @@
 {
   "scenarios": [
-    {
-      "type": "create",
-      "name": "Create Table For Subscription",
-      "endpoint": "NODE-table.obj",
-      "sql_endpoint": "NODE-table.sql_id",
-      "data": {
-        "name": "test_table",
-        "columns": [
-          {
-            "name": "emp_id",
-            "cltype": "integer",
-            "is_primary_key": true
-          },
-          {
-            "name": "name",
-            "cltype": "text"
-          },
-          {
-            "name": "salary",
-            "cltype": "bigint"
-          }
-        ],
-        "is_partitioned": false,
-        "schema": "public",
-        "spcname": "pg_default"
-      },
-      "store_object_id": true
-    },
-    {
-      "type": "create",
-      "name": "Create Publication For Subscription",
-      "endpoint": "NODE-publication.obj",
-      "sql_endpoint": "NODE-publication.sql_id",
-      "data": {
-        "name": "test_publication",
-        "evnt_insert": true,
-        "evnt_update": true,
-        "evnt_delete": true,
-        "evnt_truncate": true,
-        "pubowner": "postgres",
-        "publish_via_partition_root": false,
-        "all_table": false,
-        "only_table": false,
-        "pubtable": [{
-          "table_name": "public.test_table"
-        }],
-        "pubschema": ""
-      }
-    },
     {
       "type": "create",
       "name": "Create  Subscription",
@@ -69,7 +20,7 @@
           "copy_data": false,
           "create_slot": false,
           "enabled": false,
-          "connect": true,
+          "connect": false,
           "slot_name": "test_create_subscription",
           "sync": "remote_apply",
           "streaming": true,

web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/18_plus/create_subscription_msql.sql

@@ -1,4 +1,4 @@
 CREATE SUBSCRIPTION test_create_subscription
     CONNECTION 'host=localhost port=5434 user=postgres dbname=postgres connect_timeout=10 password=xxxxxx sslmode=prefer'
     PUBLICATION test_publication
-    WITH (connect = true, enabled = false, copy_data = false, create_slot = false, slot_name = test_create_subscription, synchronous_commit = 'remote_apply', binary = true, streaming = 'True', two_phase = false, disable_on_error = true, run_as_owner = true, password_required = true, origin = 'any', failover = false);
+    WITH (connect = false, enabled = false, copy_data = false, create_slot = false, slot_name = test_create_subscription, synchronous_commit = 'remote_apply', binary = true, streaming = 'True', two_phase = false, disable_on_error = true, run_as_owner = true, password_required = true, origin = 'any', failover = false);

web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/18_plus/test.json

@@ -1,54 +1,5 @@
 {
   "scenarios": [
-    {
-      "type": "create",
-      "name": "Create Table For Subscription",
-      "endpoint": "NODE-table.obj",
-      "sql_endpoint": "NODE-table.sql_id",
-      "data": {
-        "name": "test_table",
-        "columns": [
-          {
-            "name": "emp_id",
-            "cltype": "integer",
-            "is_primary_key": true
-          },
-          {
-            "name": "name",
-            "cltype": "text"
-          },
-          {
-            "name": "salary",
-            "cltype": "bigint"
-          }
-        ],
-        "is_partitioned": false,
-        "schema": "public",
-        "spcname": "pg_default"
-      },
-      "store_object_id": true
-    },
-    {
-      "type": "create",
-      "name": "Create Publication For Subscription",
-      "endpoint": "NODE-publication.obj",
-      "sql_endpoint": "NODE-publication.sql_id",
-      "data": {
-        "name": "test_publication",
-        "evnt_insert": true,
-        "evnt_update": true,
-        "evnt_delete": true,
-        "evnt_truncate": true,
-        "pubowner": "postgres",
-        "publish_via_partition_root": false,
-        "all_table": false,
-        "only_table": false,
-        "pubtable": [{
-          "table_name": "public.test_table"
-        }],
-        "pubschema": ""
-      }
-    },
     {
       "type": "create",
       "name": "Create  Subscription",
@@ -69,7 +20,7 @@
           "copy_data": false,
           "create_slot": false,
           "enabled": false,
-          "connect": true,
+          "connect": false,
           "slot_name": "test_create_subscription",
           "sync": "remote_apply",
           "streaming": true,