Added check for text length

ankane · ankane · commit 14ff4c934128 · 2025-09-02T12:40:55.000-07:00
diff --git a/include/pgvector/pqxx.hpp b/include/pgvector/pqxx.hpp
@@ -31,7 +31,7 @@ template <> struct string_traits<pgvector::Vector> {
     static constexpr bool converts_from_string{true};
 
     static pgvector::Vector from_string(std::string_view text) {
-        if (text.front() != '[' || text.back() != ']') {
+        if (text.size() < 2 || text.front() != '[' || text.back() != ']') {
             throw conversion_error("Malformed vector literal");
         }
 
@@ -76,7 +76,7 @@ template <> struct string_traits<pgvector::HalfVector> {
     static constexpr bool converts_from_string{true};
 
     static pgvector::HalfVector from_string(std::string_view text) {
-        if (text.front() != '[' || text.back() != ']') {
+        if (text.size() < 2 || text.front() != '[' || text.back() != ']') {
             throw conversion_error("Malformed halfvec literal");
         }
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ template <> struct string_traits<pgvector::Vector> {`
`31`	`31`	`static constexpr bool converts_from_string{true};`
`32`	`32`
`33`	`33`	`static pgvector::Vector from_string(std::string_view text) {`
`34`		`- if (text.front() != '[' \|\| text.back() != ']') {`
	`34`	`+ if (text.size() < 2 \|\| text.front() != '[' \|\| text.back() != ']') {`
`35`	`35`	`throw conversion_error("Malformed vector literal");`
`36`	`36`	`}`
`37`	`37`
`@@ -76,7 +76,7 @@ template <> struct string_traits<pgvector::HalfVector> {`
`76`	`76`	`static constexpr bool converts_from_string{true};`
`77`	`77`
`78`	`78`	`static pgvector::HalfVector from_string(std::string_view text) {`
`79`		`- if (text.front() != '[' \|\| text.back() != ']') {`
	`79`	`+ if (text.size() < 2 \|\| text.front() != '[' \|\| text.back() != ']') {`
`80`	`80`	`throw conversion_error("Malformed halfvec literal");`
`81`	`81`	`}`
`82`	`82`