Improved tests for from_string

Author: ankane

test/pqxx_test.cpp

@@ -141,6 +141,29 @@ void test_vector_to_string() {
 
 void test_vector_from_string() {
     assert(pqxx::from_string<pgvector::Vector>("[1,2,3]") == pgvector::Vector({1, 2, 3}));
+
+    try {
+        auto unused = pqxx::from_string<pgvector::Vector>("");
+        assert(false);
+    } catch (const pqxx::conversion_error& e) {
+        assert(std::string_view(e.what()) == "Malformed vector literal");
+    }
+
+    // TODO change to pqxx::conversion_error
+    try {
+        auto unused = pqxx::from_string<pgvector::Vector>("[hello]");
+        assert(false);
+    } catch (const std::invalid_argument& e) {
+        assert(true);
+    }
+
+    // TODO change to pqxx::conversion_error
+    try {
+        auto unused = pqxx::from_string<pgvector::Vector>("[4e38]");
+        assert(false);
+    } catch (const std::out_of_range& e) {
+        assert(true);
+    }
 }
 
 void test_halfvec_to_string() {
@@ -149,6 +172,21 @@ void test_halfvec_to_string() {
 
 void test_halfvec_from_string() {
     assert(pqxx::from_string<pgvector::HalfVector>("[1,2,3]") == pgvector::HalfVector({1, 2, 3}));
+
+    try {
+        auto unused = pqxx::from_string<pgvector::HalfVector>("");
+        assert(false);
+    } catch (const pqxx::conversion_error& e) {
+        assert(std::string_view(e.what()) == "Malformed halfvec literal");
+    }
+
+    // TODO change to pqxx::conversion_error
+    try {
+        auto unused = pqxx::from_string<pgvector::HalfVector>("[hello]");
+        assert(false);
+    } catch (const std::invalid_argument& e) {
+        assert(true);
+    }
 }
 
 void test_sparsevec_to_string() {