Debug

Author: ankane

include/pgvector/pqxx.hpp

@@ -164,9 +164,9 @@ template <> struct string_traits<pgvector::SparseVector> {
 
             return pgvector::SparseVector(dimensions, indices, values);
         } catch (const std::invalid_argument& e) {
-            throw conversion_error(e.what());
+            throw conversion_error("No conversion");
         } catch (const std::out_of_range& e) {
-            throw conversion_error(e.what());
+            throw conversion_error("Out of range");
         }
     }
 

test/pqxx_test.cpp

@@ -1,5 +1,4 @@
 #include <cassert>
-#include <iostream>
 #include <optional>
 #include <string>
 #include <vector>
@@ -246,8 +245,7 @@ void test_sparsevec_from_string() {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{ }/");
         assert(false);
     } catch (const pqxx::conversion_error& e) {
-        std::cout << e.what() << std::endl;
-        assert(std::string_view(e.what()) == "stoi: no conversion");
+        assert(std::string_view(e.what()) == "No conversion");
     }
 
     try {
@@ -261,7 +259,7 @@ void test_sparsevec_from_string() {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{:}/1");
         assert(false);
     } catch (const pqxx::conversion_error& e) {
-        assert(std::string_view(e.what()) == "stoi: no conversion");
+        assert(std::string_view(e.what()) == "No conversion");
     }
 
     try {
@@ -289,28 +287,28 @@ void test_sparsevec_from_string() {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{1:4e38}/1");
         assert(false);
     } catch (const pqxx::conversion_error& e) {
-        assert(std::string_view(e.what()) == "stof: out of range");
+        assert(std::string_view(e.what()) == "Out of range");
     }
 
     try {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{a:1}/1");
         assert(false);
     } catch (const pqxx::conversion_error& e) {
-        assert(std::string_view(e.what()) == "stoi: no conversion");
+        assert(std::string_view(e.what()) == "No conversion");
     }
 
     try {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{1:a}/1");
         assert(false);
     } catch (const pqxx::conversion_error& e) {
-        assert(std::string_view(e.what()) == "stof: no conversion");
+        assert(std::string_view(e.what()) == "No conversion");
     }
 
     try {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{}/a");
         assert(false);
     } catch (const pqxx::conversion_error& e) {
-        assert(std::string_view(e.what()) == "stoi: no conversion");
+        assert(std::string_view(e.what()) == "No conversion");
     }
 }