Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v4 json format #15

Closed
jlabeit opened this issue Dec 16, 2021 · 0 comments · Fixed by #16
Closed

Support v4 json format #15

jlabeit opened this issue Dec 16, 2021 · 0 comments · Fixed by #16

Comments

@jlabeit
Copy link

jlabeit commented Dec 16, 2021

Background
With the latest major release of i18next a new json format v4 has been introduced. This format is currently not supported by this project because the underlying project i18next-scanner does not support it.

Proposed solution
It seems that there are two project doing more or less the same:

  1. https://github.com/i18next/i18next-scanner
  2. https://github.com/i18next/i18next-parser

There is a discussion to merge these two projects but it seems nothing will happen there soon (i18next/i18next-scanner#216).

Currently the scanner is being used, which seems to be less maintained and does not supprot the new V4 format.
I would propose to migrate this plugin to use the second project. Just this line would need to change: https://github.com/ph1p/i18next-scanner-webpack/blob/master/index.js#L118

KhaledSakr added a commit to KhaledSakr/i18next-scanner-webpack that referenced this issue Dec 16, 2021
The reasoning for this switch is better described in the issue: ph1p#15

BREAKING CHANGE: As i18next-parser has a different API, the structure of `options` parameter completely changed.
@ph1p ph1p closed this as completed in #16 Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant