adjusting the workflow and exports

Author: niden

.github/workflows/deploy-documents.yml

@@ -43,13 +43,20 @@ jobs:
         # src/lib/design-checks.mjs and src/lib/design-refresh.mjs are copies of
         # phalcon/tools/ in phalcon/assets: the checks and the refresh of the
         # design files, the same on every Phalcon site. A download that fails,
-        # or a file that is not valid JavaScript, keeps the committed copy. The
-        # design files and the tests that come next use the new tools.
+        # a file that is not valid JavaScript, or a file that lacks an export of
+        # the committed copy keeps the committed copy. The design files and the
+        # tests that come next use the new tools.
+        env:
+          # Exits with 0 when the first file has every export of the second one.
+          EXPORTS: >-
+            const [next, last] = await Promise.all(process.argv.slice(1).map((file) => import(process.cwd() + '/' + file)));
+            process.exit(Object.keys(last).every((name) => name in next) ? 0 : 1);
         run: |
           for file in design-checks.mjs design-refresh.mjs; do
             new="src/lib/${file%.mjs}.new.mjs"
 
-            if curl -fsSL --max-time 30 -o "$new" "https://assets.phalcon.io/phalcon/tools/$file" && node --check "$new"; then
+            if curl -fsSL --max-time 30 -o "$new" "https://assets.phalcon.io/phalcon/tools/$file" && node --check "$new" \
+              && node --input-type=module -e "$EXPORTS" "$new" "src/lib/$file"; then
               mv "$new" "src/lib/$file"
             else
               rm -f "$new"

scripts/sources.test.mjs

@@ -153,5 +153,13 @@ test("the deploy workflow gets the design tools first, and keeps the committed c
   assert.ok(step < workflow.indexOf("run: node scripts/update-tokens.mjs"), "the step must come before the design files");
   assert.match(workflow, /for file in design-checks\.mjs design-refresh\.mjs; do/);
   assert.match(workflow, /new="src\/lib\/\$\{file%\.mjs\}\.new\.mjs"/);
-  assert.match(workflow, /curl -fsSL --max-time 30 -o "\$new" "https:\/\/assets\.phalcon\.io\/phalcon\/tools\/\$file" && node --check "\$new"; then/);
+  assert.match(workflow, /curl -fsSL --max-time 30 -o "\$new" "https:\/\/assets\.phalcon\.io\/phalcon\/tools\/\$file" && node --check "\$new"/);
+});
+
+test("the deploy workflow keeps the committed design tools when a new file lacks one of their exports", () => {
+  // The site imports the functions by name: a new file with an export less would stop the refresh.
+  const workflow = readFileSync(new URL(".github/workflows/deploy-documents.yml", root), "utf8");
+
+  assert.match(workflow, /node --check "\$new" \\\n\s+&& node --input-type=module -e "\$EXPORTS" "\$new" "src\/lib\/\$file"; then/);
+  assert.match(workflow, /Object\.keys\(last\)\.every\(\(name\) => name in next\)/);
 });