Open
Conversation
Owner
|
I'm not too convinced by this additional feature TBH. String interop with In short, I don't think the additional code (and with it, maintenance) is worth the extra functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi, there!
When I posted this issue, I was misunderstanding this library's intention to use
v-htmlrather than the{{}}syntax that vue provides.I thought it would be nicer if there's an option to use
{{}}, as it is safer in terms of XSS attack, which is what Vue.js itself suggests in the docs.So, this PR intends to add support for such case, while preserving the original behavior of supporting
v-html.Notice:
vue-linkifykind of worked with{{}}syntax even without this PR, but it did have a re-render issue above, so this PR tries to solve that as well :)Example
With this PR,
will be converted to