Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method missing: SpCommandGroup>>#asToolbarPresenter #1601

Open
koendehondt opened this issue Sep 15, 2024 · 0 comments
Open

Method missing: SpCommandGroup>>#asToolbarPresenter #1601

koendehondt opened this issue Sep 15, 2024 · 0 comments

Comments

@koendehondt
Copy link
Contributor

Context: Pharo 12 and Pharo 13

SpCommandGroup has these 4 methods:

  • asMenuBarPresenter
  • asMenuBarPresenterWith:
  • asMenuPresenter
  • asMenuPresenterWith:

but it does not have:

  • asToolbarPresenter
  • asToolbarPresenterWith:

Due to the missing methods, developers have to write:

| toolbarCommandGroup |
toolBar := self newToolbar.
toolbarCommandGroup := self rootCommandsGroup / 'ToolBar'.
SpToolbarPresenterBuilder new
	toolbarPresenter: toolBar;
	visit: toolbarCommandGroup

instead of:

toolBar := (self rootCommandsGroup / 'ToolBar') asToolbarPresenter

The purpose of this ticket is to add the two methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant