Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to batch correction module - specify correction sample. #71

Open
Gscorreia89 opened this issue May 19, 2021 · 2 comments
Open

Improvements to batch correction module - specify correction sample. #71

Gscorreia89 opened this issue May 19, 2021 · 2 comments
Assignees
@Gscorreia89 @gordondavies
Labels
enhancement New feature or request Three days

Comments

@Gscorreia89
Copy link
Member

The batch correction module should have an argument to specify which specific sample of "Precision Reference" type should be used for LOWESS correction.
@Gscorreia89 Gscorreia89 added enhancement New feature or request Three days labels May 19, 2021
@Gscorreia89 Gscorreia89 self-assigned this May 19, 2021
@Gscorreia89
Copy link
Member Author

New features being added here: https://github.com/phenomecentre/nPYc-Toolbox/tree/feature/batchCorrectionUpdates

@Gscorreia89
Copy link
Member Author

Functionality is already implemented (including the accompanying unittests) in the https://github.com/phenomecentre/nPYc-Toolbox/tree/feature/batchCorrectionUpdates branch. After some real time example testing confirms all is good the pull request can be merged into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gscorreia89 Gscorreia89

@gordondavies gordondavies

Labels
enhancement New feature or request Three days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gscorreia89 @gordondavies