Enrich the variant preview

[priesgo]

[alanwilter]

@priesgo I did #249 to bring back the stuff you've once created. Have a look again but I guess you may close this issue.

[pontikos]

I'm closing this as there no updates from @priesgo and insufficient information provided.
Furthermore comment from @alanwilter suggests this has been achieved.

[alanwilter]

Sorry, this is not done, there's only clinvar so far, I'm reopening it.

[pontikos]

Ok please add further information as I don't understand what this issue is about.

…

On Tue, 18 May 2021, 22:03 Alan Silva, ***@***.***> wrote: Sorry, this is not done, there's only clinvar so far, I'm reopening it. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#222 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5MN5E6IPLIEMJTQIONNODTOLIZPANCNFSM4TOTH2GQ> .

[alanwilter]

Current code, note the TODO @priesgo once added.

def _get_preview(chrom, pos, ref, alt):
    # queries for Clinvar clinical significance
    clinical_significance = _fetch_clinvar_clinical_significance(chrom, pos, ref, alt)
    preview = {"Clinvar": clinical_significance}
    # TODO: add more things here eg: GnomAD frequency, SO effect
    return jsonify(preview)

But to get, e.g., GnomaAD, we need attention to #337. I don't know what's SO.

[pontikos]

Please ignore SO it is not required at this point.

…

On Tue, 18 May 2021, 22:14 Alan Silva, ***@***.***> wrote: Current code. def _get_preview(chrom, pos, ref, alt): # queries for Clinvar clinical significance clinical_significance = _fetch_clinvar_clinical_significance(chrom, pos, ref, alt) preview = {"Clinvar": clinical_significance} # TODO: add more things here eg: GnomAD frequency, SO effect return jsonify(preview) But to get, e.g., GnomaAD, we need attention to #337 <#337>. I don't know what's SO. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#222 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5MN5G7JO6WIUYDAF5JANTTOLKELANCNFSM4TOTH2GQ> .