Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large database payloads can fail #250

Open
brettfiedler opened this issue May 10, 2024 · 0 comments
Open

Large database payloads can fail #250

brettfiedler opened this issue May 10, 2024 · 0 comments

Comments

@brettfiedler
Copy link
Member

brettfiedler commented May 10, 2024

Look for other places where this payload error can happen.

Inspecting the api, here is where this can happen again potentially:

  • /api/spaces/:spaceName/programs (POST): - When you create a new program from the camera page. Will happen if code is too large.
  • /api/spaces/:spaceName/programs/add-premade-program (POST): Sends a single program to playground from Creator, part of the chunking from Large projects are too large to send to playground! #188. If the program is too large, we will hit this.
  • /api/creator/templates (PUT): Saves a new template for creator. Just like this issue, if the template is has ~200 components or more, we will hit this.
  • /api/creator/templates/update/save (PUT): Again, if template is massive when you update it, this will happen.
  • /api/creator/maintenance/updateSchema (POST): (Not really worried about this, its for development use)

Could also happen if the user tries to upload massive image/audio files.

The size limits are way bigger for receiving data from the server. Since our entire db is less than 1mb, we don't have to worry about this when loading data from the db.

In summary, one of these is from the original paper programs code and the rest are not likely enough to hit to prioritize right now (IMO). However this may be something @brettfiedler wants to track for project management. I think this is most likely to happen again for massive programs (where a single program has >200 components or tons of custom code).

Originally posted by @jessegreenberg in #202 (comment)

Noting that this can happen as described above. Will wait until we hit this scenario to act.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant