fix: race testcode

philippseith · philippseith · commit 07e4938ab442 · 2021-11-06T14:04:48.000+01:00
diff --git a/testingconnection_test.go b/testingconnection_test.go
@@ -46,9 +46,9 @@ func (t *testingConnection) Timeout() time.Duration {
 }
 
 func (t *testingConnection) ConnectionID() string {
+	connNumMx.Lock()
+	defer connNumMx.Unlock()
 	if t.connectionID == "" {
-		defer connNumMx.Unlock()
-		connNumMx.Lock()
 		connNum++
 		t.connectionID = fmt.Sprintf("test%v", connNum)
 	}

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,9 @@ func (t *testingConnection) Timeout() time.Duration {`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`func (t *testingConnection) ConnectionID() string {`
	`49`	`+ connNumMx.Lock()`
	`50`	`+ defer connNumMx.Unlock()`
`49`	`51`	`if t.connectionID == "" {`
`50`		`- defer connNumMx.Unlock()`
`51`		`- connNumMx.Lock()`
`52`	`52`	`connNum++`
`53`	`53`	`t.connectionID = fmt.Sprintf("test%v", connNum)`
`54`	`54`	`}`