Skip to content

Commit 8da657b

Browse files
committed
fix: testing codecov configuration
1 parent 5515fac commit 8da657b

File tree

2 files changed

+13
-20
lines changed

2 files changed

+13
-20
lines changed

Diff for: .github/workflows/main.yml

+11-18
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ on:
55
push:
66
branches:
77
- master
8-
tags: []
98
pull_request:
109

1110
jobs:
@@ -21,16 +20,16 @@ jobs:
2120
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
2221
version: v1.29
2322

24-
npminstall:
25-
name: npminstall
26-
runs-on: ubuntu-latest
27-
steps:
28-
- uses: actions/checkout@v2
29-
- uses: actions/setup-node@v1
30-
with:
31-
node-version: '14'
32-
- run: cd signalr_test
33-
- run: npm install
23+
# npminstall:
24+
# name: npminstall
25+
# runs-on: ubuntu-latest
26+
# steps:
27+
# - uses: actions/checkout@v2
28+
# - uses: actions/setup-node@v1
29+
# with:
30+
# node-version: '14'
31+
# - run: cd signalr_test
32+
# - run: npm install
3433

3534
test:
3635
name: Test
@@ -48,18 +47,12 @@ jobs:
4847
- name: Run Unit tests.
4948
run: make test-coverage
5049

51-
reportcoverage:
52-
name: Report Coverage
53-
runs-on: ubuntu-latest
54-
needs: [test]
55-
continue-on-error: true
56-
steps:
5750
- name: Upload Coverage report to CodeCov
5851
uses: codecov/[email protected]
5952
with:
6053
token: ${{secrets.CODECOV_TOKEN}}
6154
file: ./coverage.txt
62-
55+
6356
build:
6457
name: Build
6558
runs-on: ubuntu-latest

Diff for: codecov.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
codecov:
2-
require_ci_to_pass: yes
2+
require_ci_to_pass: true
33

44
coverage:
55
precision: 2
@@ -17,7 +17,7 @@ parsers:
1717
comment:
1818
layout: "reach,diff,flags,files,footer"
1919
behavior: default
20-
require_changes: no
20+
require_changes: false
2121

2222
ignore:
2323
- chatsample/**/*

0 commit comments

Comments
 (0)