You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Macros are used extensively within the code, especially in the emulator interface (memory access). The way they're used rarely follows best practice, looks messy, and confuses the way the code works. Furthermore, they're large and hard to follow.
At the very least the access-check functions should be reimplemented as static inline functions -- other macros should be reviewed.
The text was updated successfully, but these errors were encountered:
Macros are used extensively within the code, especially in the emulator interface (memory access). The way they're used rarely follows best practice, looks messy, and confuses the way the code works. Furthermore, they're large and hard to follow.
At the very least the access-check functions should be reimplemented as static inline functions -- other macros should be reviewed.
The text was updated successfully, but these errors were encountered: