-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default root layout's html content width issue. #5656
Comments
Hi @Dinesh563! 👋 The current behavior was introduced in 7ab3d91 (later amended by 3085b13) in response to #5101. I agree the reserved space can look strange, particularly for pages that would otherwise have no scrollbars and I have removed that in some projects. But I think any changes to the current root template would need to take the original issue it was trying to solve into account, and at least test that a proposed patch doesn't accidentally re-introduce the problem. Since the template is just a template, we can also change it in our projects if the design asks for it, and deal with the consequences ourselves (we all might have different trade-offs at hand, for example not be using modals at all). |
I would probably just remove the class altogether. :) |
I'd also vote for just removing it. If people don't like the reflow, they can add the appropriate scrollbar-gutter setting themselves and decide on their own if they want, https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter |
cool!, removed the class :) . |
Environment
Actual behavior
On Generating new phoenix project with
mix phx.new
the default root layout body element's width is not up to the full screen.which generates a small gap between the right wall of the screen and the html content.
Note: i have not touched or written any css.
Expected behavior
The default root layout's html must have width set to full screen.There should not be any gap between html content and the right screen.
The text was updated successfully, but these errors were encountered: