Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #3

Open
3 of 5 tasks
sabas opened this issue Dec 21, 2016 · 6 comments
Open
3 of 5 tasks

TODO #3

sabas opened this issue Dec 21, 2016 · 6 comments

Comments

@sabas
Copy link
Contributor

sabas commented Dec 21, 2016

  • Segments D00B missing content
  • Service codes from D09A
  • Directory D16B
  • Generate again the directories from D06A backwards
  • Rerun on all directories
@swiffer
Copy link

swiffer commented Sep 7, 2017

Hi,

detected a spec failure in mscons.xml for D04B. Should be a group for SG10 but is a segment currently. Don't know if it's related to your TODO but as you're mentioning to Generate again directories for D06A backwards perhaps this is related.

`      <group id="SG9" maxrepeat="9999">
        <segment id="LIN" maxrepeat="1" required="true"/>
        <segment id="PIA" maxrepeat="9"/>
        <segment id="IMD" maxrepeat="9"/>
        <segment id="PRI" maxrepeat="9"/>
        <segment id="NAD" maxrepeat="9"/>
        <segment id="MOA" maxrepeat="9"/>
        <group id="SG10" maxrepeat="9999" required="true">
          <segment id="QTY" maxrepeat="1" required="true"/>
          <segment id="DTM" maxrepeat="9"/>
          <segment id="STS" maxrepeat="9"/>
        </group>
      </group>

Would love to see this fixed. Thanks!

@sabas
Copy link
Contributor Author

sabas commented Sep 7, 2017

Looks like the EDMDParser doesn't take in account groups that nested... :| Needs a smarter way to do that

@sabas
Copy link
Contributor Author

sabas commented Sep 9, 2017

Ok, I rewrote the parser and it works.

@sabas
Copy link
Contributor Author

sabas commented Sep 10, 2017

@swiffer I uploaded the newer data for D97A to D17A, could you please check?

@swiffer
Copy link

swiffer commented Sep 11, 2017

hey @sabas at least the the mscons i mentioned above is looking correct now. would be great to release an updated package on packgist.org
thanks!

@sabas
Copy link
Contributor Author

sabas commented Sep 11, 2017

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants