WP_CLI\Formatter::display_items should use \Iterator, not Iterator

[mundschenk-at]

WP_CLI\Formatter::display_items has Iterator (without the \) set as the type of its parameter $items, expanding to WP_CLI\Iterator.

[szepeviktor]

Isn't it imported?
https://github.com/wp-cli/wp-cli/blob/1e2aa1155ee20776fe81d22b6e79e6d48aa358b1/php/WP_CLI/Formatter.php#L7

[szepeviktor]

I see!
Imported classes are not modified in PHPDoc blocks.
FQCN should be used in PHPDoc (and in exceptions) but the WP-CLI project does not seem to be doing that.

[szepeviktor]

Talked about in GiacoCorsiglia/php-stubs-generator#8

[szepeviktor]

@mundschenk-at If you convince @schlessera to always use FQCN ...

[mundschenk-at]

Unlikely. Always using FQCN in doc blocks makes them very unwieldy if you have deeply nested namespaces.

[mundschenk-at]

FQCN should be used in PHPDoc (and in exceptions) but the WP-CLI project does not seem to be doing that.

Not according to https://docs.phpdoc.org/3.0/guide/guides/types.html

[szepeviktor]

This is not a technical rule. It makes PHPDoc blocks easy to understand.