Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nyholm/symfony-bundle-test to fully support Symfony 6 #476

Open
bocharsky-bw opened this issue Apr 4, 2022 · 5 comments
Open

Upgrade nyholm/symfony-bundle-test to fully support Symfony 6 #476

bocharsky-bw opened this issue Apr 4, 2022 · 5 comments

Comments

@bocharsky-bw
Copy link
Member

Recently, the new v2.0.0 of nyholm/symfony-bundle-test just has been released, see SymfonyTest/symfony-bundle-test#65 . Now we need to upgrade to it and fix tests here to fully support Symfony 6 with this bundle.

Anyone who could work on it?

@rvanlaak
Copy link
Member

rvanlaak commented Apr 6, 2022

Was https://github.com/SymfonyTest/symfony-bundle-test blocking us from making this bundle compatible with Symfony 6?

@bocharsky-bw
Copy link
Member Author

bocharsky-bw commented Apr 6, 2022

I can't 100% be sure already, but IIRC it was one of the reasons. You can see that some Symfony packages are still 5.4: https://github.com/php-translation/symfony-bundle/runs/5816280519?check_suite_focus=true

Though, I haven't started using this bundle on Symfony 6 yet, so can't say much without a deeper debugging, maybe the problem is only internal, i.e. maybe we just do not install ALL symfony 6 packages on our CI

@byhaskell
Copy link

Greetings.
Are there any changes in the status of the bundle installation on Symphony 6.2?
When installing, now there is an error about the PHP version.

@welcoMattic
Copy link
Member

What is your needs @byhaskell? If you use Adapters from the bundle, you can switch to use natives Translation Providers from Symfony itself.

Otherwise, you are welcome to help us upgrading the bundle for 6.2 :)

@byhaskell
Copy link

@welcoMattic In general, I'm talking about the whole translator package))
Alas, I am not familiar with the development of open source projects, if I have time I can try, but in the near future it is not possible. I asked in the hope that perhaps there are dates from the one who is involved))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants