Deprecate ZEND_SIZE_MAX and point to SIZE_MAX directly #19244
Merged
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jul 26, 2025
Member
|
I don't see any problem regarding the availability of |
Member
|
I agree with @cmb69 |
marc-mabe
changed the title
marc-mabe
force-pushed
the
win_size_max
branch
from
d1789fe to
8e9310e
Compare
Contributor
Author
cmb69
approved these changes
Aug 28, 2025
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me now.
dstogov
approved these changes
Sep 1, 2025
Member
|
Actually, not an ABI break (not even an API break). @bukka, are you fine with this? |
Contributor
Author
|
@bukka Can this one be merged now? |
bukka
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIZE_MAXis available on windows as well.Also,
SIZE_MAXis already used all over the place whileZEND_SIZE_MAXwas used only once.