XHProf: add .arclint, fix some minor issues

Summary: Add a .arclint file and fix some stray tabs and whitespace issues.

Test Plan: Built xhprof, ran tests (some failures, but preexisting).

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D10372

Author: epriestley

.arclint

@@ -0,0 +1,30 @@
+{
+  "exclude": [
+    "(^xhprof_html/jquery/)",
+    "(^xhprof_html/docs/)",
+    "(^extension/Makefile.local)"
+  ],
+  "linters": {
+    "chmod": {
+      "type": "chmod"
+    },
+    "filename": {
+      "type": "filename"
+    },
+    "generated": {
+      "type": "generated"
+    },
+    "merge-conflict": {
+      "type": "merge-conflict"
+    },
+    "nolint": {
+      "type": "nolint"
+    },
+    "text-without-length": {
+      "type": "text",
+      "severity": {
+        "3": "disabled"
+      }
+    }
+  }
+}

.gitignore

@@ -4,3 +4,10 @@ extension/*
 !extension/php_xhprof.h
 !extension/tests/
 !extension/xhprof.c
+
+extension/tests/*.sh
+extension/tests/*.exp
+extension/tests/*.out
+extension/tests/*.diff
+extension/tests/*.log
+extension/tests/*.php

LICENSE

@@ -1,4 +1,3 @@
-
                                  Apache License
                            Version 2.0, January 2004
                         http://www.apache.org/licenses/

README

@@ -3,5 +3,3 @@ For installation and usage notes refer to:
 
 To view the latest version of the doc, go to:
   http://pecl.php.net/package/xhprof ---> [View Documentation]
-
-

extension/config.m4

@@ -1,4 +1,3 @@
-
 PHP_ARG_ENABLE(xhprof, whether to enable xhprof support,
 [ --enable-xhprof      Enable xhprof support])
 

extension/php_xhprof.h

@@ -42,4 +42,4 @@ PHP_FUNCTION(xhprof_disable);
 PHP_FUNCTION(xhprof_sample_enable);
 PHP_FUNCTION(xhprof_sample_disable);
 
-#endif	/* PHP_XHPROF_H */
+#endif /* PHP_XHPROF_H */

extension/tests/common.php

@@ -32,4 +32,3 @@ function print_canonical($xhprof_data) {
     echo "\n";
   }
 }
-

extension/xhprof.c

@@ -2016,4 +2016,3 @@ static inline void hp_array_del(char **name_array) {
     efree(name_array);
   }
 }
-

xhprof_html/css/xhprof.css

@@ -79,4 +79,3 @@ ul.xhprof_actions li a:hover {
   background:#3B5998 none repeat scroll 0 0;
   color:#FFFFFF;
 }
-

xhprof_lib/display/typeahead_common.php

@@ -77,4 +77,3 @@
 foreach ($functions as $f) {
   echo $f."\n";
 }
-

xhprof_lib/display/xhprof.php

@@ -1003,7 +1003,7 @@ function print_pc_array($url_params, $results, $base_ct, $base_info, $parent,
 
 function print_source_link($info) {
   if (strncmp($info['fn'], 'run_init', 8) && $info['fn'] !== 'main()') {
-	if (defined('XHPROF_SYMBOL_LOOKUP_URL')) {
+    if (defined('XHPROF_SYMBOL_LOOKUP_URL')) {
       $link = xhprof_render_link(
         'source',
         XHPROF_SYMBOL_LOOKUP_URL . '?symbol='.rawurlencode($info["fn"]));

xhprof_lib/utils/xhprof_lib.php

@@ -943,4 +943,3 @@ function xhprof_get_matching_functions($q, $xhprof_data) {
 
   return ($res);
 }
-