fix: Add consideration of Node\Attribute to FileVisitor (#444)

* fix: Add consideration of Node\Attribute to FileVisitor
* Add test

---------

Co-authored-by: Philipp Lohmann <[email protected]>

Author: philipp-yoummday

src/Analyzer/FileVisitor.php

@@ -224,6 +224,15 @@ public function enterNode(Node $node): void
                     ->addDependency(new ClassDependency($returnType->toString(), $returnType->getLine()));
             }
         }
+
+        if ($node instanceof Node\Attribute) {
+            $nodeName = $node->name;
+
+            if ($nodeName instanceof Node\Name\FullyQualified) {
+                $this->classDescriptionBuilder
+                    ->addDependency(new ClassDependency(implode('\\', $nodeName->getParts()), $node->getLine()));
+            }
+        }
     }
 
     public function getClassDescriptions(): array

tests/E2E/PHPUnit/CheckAttributeDependencyTest.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Arkitect\Tests\E2E\PHPUnit;
+
+use Arkitect\ClassSet;
+use Arkitect\Expression\ForClasses\NotDependsOnTheseNamespaces;
+use Arkitect\Expression\ForClasses\ResideInOneOfTheseNamespaces;
+use Arkitect\Rules\Rule;
+use PHPUnit\Framework\ExpectationFailedException;
+use PHPUnit\Framework\TestCase;
+
+class CheckAttributeDependencyTest extends TestCase
+{
+    /**
+     * @requires PHP >= 8.0
+     */
+    public function test_assertion_should_fail_on_invalid_dependency(): void
+    {
+        $set = ClassSet::fromDir(__DIR__.'/../_fixtures/attributes');
+
+        $rule = Rule::allClasses()
+            ->that(new ResideInOneOfTheseNamespaces('App\Service'))
+            ->should(new NotDependsOnTheseNamespaces('App\Service\Invalid'))
+            ->because('i said so');
+
+        $expectedExceptionMessage = 'depends on App\Service\Invalid\Attr, but should not depend on these namespaces: App\Service\Invalid because i said so';
+
+        $this->expectException(ExpectationFailedException::class);
+        $this->expectExceptionMessage($expectedExceptionMessage);
+
+        ArchRuleTestCase::assertArchRule($rule, $set);
+    }
+}

tests/E2E/_fixtures/attributes/Foo.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Service;
+
+use App\Service\Invalid\Attr as InvalidAttr;
+use App\Service\Valid\Attr as ValidAttr;
+
+#[ValidAttr, InvalidAttr]
+class Foo
+{
+}

tests/E2E/_fixtures/attributes/Invalid/Attr.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Service\Invalid;
+
+use Attribute;
+
+#[Attribute]
+class Attr
+{
+}

tests/E2E/_fixtures/attributes/Valid/Attr.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Service\Valid;
+
+use Attribute;
+
+#[Attribute]
+class Attr
+{
+}